-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 1D Spline interpolation on GPU #2257
Comments
Should we do this in a separate package? Maybe |
Currently, we just need a single function, so I was thinking of adding this in |
https://github.com/JuliaMath/Interpolations.jl apparently is GPU compatible? |
This would be useful for ClimaLSM as well. Lots of Spline1D are used there. |
Before we can make progress on solving the problem, we need to clarify exactly what the problem is. Can we collect all the places we do this?
There will be some overlap with regridding/remapping: lets just consider places where we need it for input data (forcings, initial conditions, trace gas concentrations, topography) |
Current ClimaLSM interpolating function uses:
|
Please, correct if I am wrong, but we can also assume that data is provided on constant and known time intervals (and if not, we will pre-process to do so). |
For things like precipitation, do you have point values or totals? (i.e. if you have totals, presumably you would want conservative interpolation so that the total interpolated precipitation matches the source data) |
It looks like fluxes and precip are given as accumulations in ERA5: https://confluence.ecmwf.int/pages/viewpage.action?pageId=82870405#ERA5:datadocumentation-Table3 It would be good to be conservative for these. but for parameters describing the soil/vegetation, a simpler regridding would suffice (but we can use a conservative one also) |
The two bits that I'm aware of:
|
Would linear interpolation suffice for these?
You would still need temporal interpolation during the simulation though? |
Yes
Yes, but very coarse one. - I have one dataset per month. |
Does the data represent snapshots (e.g. end of month values) or averages (over the month)? |
Monthly mean |
This issue says "Add support for 1D spline interpolation on GPU", should we update the title? Or make a separate issue? |
Precipitation needs to be given as a flux too, units of mm.s-1. A mm of rain is equivalent to 1 kg.m-2. It is just a simple conversion needed. Even if it is cumulative rain in the previous 30 min, or whatever, we take that volume of rain and divide by the time window. |
We currently use
Spline1D
interpolation fromDierckx
package at a couple of locations inClimaAtmos
.However, this package is not GPU compatible.
We would like to add a
Spline1D
function that is GPU compatible inClimaAtmos.jl
The text was updated successfully, but these errors were encountered: