Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fig config diagnostic merging; print only on root #1189

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Conversation

juliasloan25
Copy link
Member

Purpose

This PR does 2 distinct things:

  1. Fix merging of diagnostics specified in the coupler and atmosphere. Previously, atmos_config_dict["diagnostics"] was overwritten by the coupler config_dict["extra_atmos_diags"]. Now these additional diagnostics are appended, so we output all diagnostics.
  2. Initialize the ClimaComms communication context immediately after creating the config_dict, so all printing happens on root in the MPI case

@akshaysridhar
Copy link
Member

akshaysridhar commented Feb 13, 2025

Thanks @juliasloan25 . Can confirm following this change that diagnostics other than the default set are parsed correctly.

@akshaysridhar
Copy link
Member

akshaysridhar commented Feb 13, 2025

@juliasloan25 Would splitting up the 2 commits help with this ? It would be helpful to have at least the diagnostic fix as part of the main branch. (I've manually included the diagnostic update commit for now)

@juliasloan25
Copy link
Member Author

@juliasloan25 Would splitting up the 2 commits help with this ? It would be helpful to have at least the diagnostic fix as part of the main branch. (I've manually included the diagnostic update commit for now)

Sorry for the delay - there was a bug with the diagnostic fix that only appeared with some configs. It is fixed now in this PR

@juliasloan25 juliasloan25 merged commit 3422eb5 into main Feb 13, 2025
11 checks passed
@juliasloan25 juliasloan25 deleted the js/configs branch February 13, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants