Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend BCReader interpolate_data tests #384

Closed
juliasloan25 opened this issue Aug 7, 2023 · 1 comment
Closed

extend BCReader interpolate_data tests #384

juliasloan25 opened this issue Aug 7, 2023 · 1 comment
Assignees
@juliasloan25

Comments

@juliasloan25
Copy link
Member

Our current tests for BCReader.interpolate_data don't test all possible cases. We need to add a new one to test the case where we try to interpolate data at a date that appears in the input file.

See CliMA/ClimaLand.jl#285 for more details
@juliasloan25 juliasloan25 self-assigned this Aug 7, 2023
@LenkaNovak LenkaNovak added this to the O5.1.5 (coupler) ClimaUtilities.jl - shared utility package milestone Feb 21, 2024
@juliasloan25 juliasloan25 removed this from the O5.1.5 (coupler) ClimaUtilities.jl - shared utility package milestone Apr 17, 2024
@juliasloan25
Copy link
Member Author

will switch to ClimaUtilities soon - don't need to implement this

@juliasloan25 juliasloan25 closed this as not planned Won't fix, can't repro, duplicate, stale May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juliasloan25 juliasloan25

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LenkaNovak @juliasloan25