Add AMIP calibration pipeline #1187
Conversation
nefrathenrici
force-pushed
the
ne/calibration
branch
7 times, most recently
from
5d64059 to
40ec6c2
Compare
nefrathenrici
force-pushed
the
ne/calibration
branch
from
40ec6c2 to
e753038
Compare
|
|
||
| for m in 1:ensemble_size | ||
| member_path = CAL.path_to_ensemble_member(output_dir, iteration, m) | ||
| simdir_path = joinpath(member_path, "model_config/output_active/clima_atmos") |
There was a problem hiding this comment.
I don't think you need to go into the model_config/ directory here, but I'm not sure what member_path returns so it may be correct
| simdir_path = joinpath(member_path, "model_config/output_active/clima_atmos") | |
| simdir_path = joinpath(member_path, "output_active/clima_atmos") |
There was a problem hiding this comment.
I think the model_config comes from the name of the config file (model_config.yml). I could change this with the job_id, it would probably be good to keep a consistent job_id for calibration runs.
There was a problem hiding this comment.
If job_id = model_config this path will be right, but I'm not sure job_id is being set (the default is nothing)
There was a problem hiding this comment.
The job_id gets set to the name of the YAML file, I don't think it is ever nothing after the get_coupler_config_dict func:
job_id = isnothing(job_id) ? string(split(split(config_file, '/')[end], '.')[1]) : job_id
https://github.com/CliMA/ClimaCoupler.jl/blob/main/experiments/ClimaEarth/user_io/arg_parsing.jl#L26
Since this PR is only manually tested I would like to run the calibration once a week, should I make a new pipeline or do you think we could put this in the longruns?
There was a problem hiding this comment.
Ahh yes you're right, I missed that line.
Let's add it to the longruns since we already have a lot of coupler pipelines
nefrathenrici
force-pushed
the
ne/calibration
branch
from
1e20a5a to
0136119
Compare
Purpose
Add the initial AMIP calibration pipeline with a trivial perfect model experiment.
To-do
Content