add coupler fields based on simulation types #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
commented
Feb 25, 2025
| @@ -185,11 +185,11 @@ Interfacer.get_field(sim::ClimaAtmosSimulation, ::Val{:thermo_state_int}) = | |||
| CC.Spaces.level(sim.integrator.p.precomputed.ᶜts, 1) | |||
| Interfacer.get_field(atmos_sim::ClimaAtmosSimulation, ::Val{:water}) = | |||
| ρq_tot(atmos_sim.integrator.p.atmos.moisture_model, atmos_sim.integrator) | |||
| function Interfacer.update_field!(sim::ClimaAtmosSimulation, ::Val{:surface_temperature}, csf) | |||
There was a problem hiding this comment.
This is just unifying this function call with other update_field!s
juliasloan25
force-pushed
the
js/csf
branch
2 times, most recently
from
ab49765 to
17c5fa6
Compare
6 tasks
imreddyTeja
approved these changes
Feb 26, 2025
Sbozzolo
reviewed
Feb 26, 2025
juliasloan25
force-pushed
the
js/csf
branch
5 times, most recently
from
e92eabc to
ccb474f
Compare
Sbozzolo
reviewed
Feb 26, 2025
Sbozzolo
reviewed
Feb 27, 2025
Sbozzolo
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
closes #1206
This makes the coupler design more flexible to accommodate a wide variety of component models. When we add the full land model, it will add the following coupler fields:
Content