Fix ITime issue with saveat #1208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks good! Could you also add the following lines to config/ci_configs/amip_coarse_ft32.yml please? That way we'll exercise those options in our regular CI and we can catch issues like this before they get to the benchmarks.
dt_save_state_to_disk: "Inf"
dt_save_to_sol: "Inf"
ph-kev
force-pushed
the
kp/itime-bug
branch
3 times, most recently
from
de9a6bb to
64080db
Compare
| @@ -11,3 +11,5 @@ precip_model: "0M" | |||
| rad: "allskywithclear" | |||
| t_end: "10days" | |||
| vert_diff: "true" | |||
| dt_save_state_to_disk: "Inf" | |||
| dt_save_to_sol: "Inf" | |||
There was a problem hiding this comment.
Line 4 of this file has dt_save_to_sol: "100days", which should be removed. Also, we try to keep the configs alphabetized so it's easier to compare them (and find duplicate entries like this). Could you alphabetize the new entries please?
juliasloan25
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
saveat = Inf, it is not possible to make anITime. When this happens, we will instead pass in an empty array forsaveat.