Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ITime issue with saveat #1208

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix ITime issue with saveat #1208

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config/ci_configs/amip_coarse_ft32.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
FLOAT_TYPE: "Float32"
apply_limiter: false
co2: "maunaloa"
dt_save_to_sol: "100days"
dt_save_state_to_disk: "Inf"
dt_save_to_sol: "Inf"
energy_check: false
h_elem: 6
mode_name: "amip"
Expand Down
10 changes: 7 additions & 3 deletions experiments/ClimaEarth/user_io/arg_parsing.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,20 +61,24 @@ function get_coupler_args(config_dict::Dict)
date0 = date = Dates.DateTime(config_dict["start_date"], Dates.dateformat"yyyymmdd")
Δt_cpl = Float64(Utilities.time_to_seconds(config_dict["dt_cpl"]))
saveat = Float64(Utilities.time_to_seconds(config_dict["dt_save_to_sol"]))
saveat = promote(t_start:saveat:t_end..., t_end)
if use_itime
t_end = ITime(t_end, epoch = date0)
t_start = ITime(t_start, epoch = date0)
Δt_cpl = ITime(Δt_cpl, epoch = date0)
times = promote(t_end, t_start, Δt_cpl, ITime.(values(config_dict["component_dt_dict"]))...)
t_end, t_start, Δt_cpl = (times[1], times[2], times[3])
saveat = ITime(Float64(Utilities.time_to_seconds(config_dict["dt_save_to_sol"])))
saveat = [promote([t_start:saveat:t_end..., t_end]...)...]
component_dt_dict =
Dict(component => first(promote(ITime(dt), t_end)) for (component, dt) in config_dict["component_dt_dict"])
else
component_dt_dict = config_dict["component_dt_dict"]
end
if saveat != Inf
use_itime && (saveat = ITime(saveat))
saveat = [promote([t_start:saveat:t_end..., t_end]...)...]
else
saveat = typeof(t_start)[]
end

# Checkpointing information
checkpoint_dt = config_dict["checkpoint_dt"]

Expand Down
Loading