add default get_field methods #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasloan25
force-pushed
the
js/get_field_defaults
branch
from
45d4a99 to
0a7ac9c
Compare
imreddyTeja
reviewed
Feb 28, 2025
juliasloan25
force-pushed
the
js/get_field_defaults
branch
from
0a7ac9c to
e9c1235
Compare
imreddyTeja
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add default methods for
get_fieldmethods that are commonly not extended for surface models. These return reasonable default values, and can be extended by surface models that won't use the defaults (e.g. the full land model).I decided to add these now since adding the full land simulation adds some new
get_fieldmethods for surface model properties, e.g. emissivity, that have previously been assumed to have default values. This PR reduces code duplication by moving those common default values into default methods, instead of defining the same defaults for multiple surface models.At first I added this as part of #1199, but I pulled it into a separate PR to make that one a little smaller.