Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use recursion instead of generated function #252

Merged
merged 1 commit into from
Feb 25, 2024
Merged

Use recursion instead of generated function #252

merged 1 commit into from
Feb 25, 2024

Conversation

charleskawczynski
Copy link
Member

This PR changes fused_increment to use recursion instead of a generated function. I think this partially addresses #251

@charleskawczynski
Copy link
Member Author

This passes the same tests, but the 1:s-loop unrolling issue stands whether we're using a generated function or recursion. I'm going to merge this now, and see what changes are needed to get this fully unrolled/fused.

@charleskawczynski charleskawczynski merged commit bad8b66 into main Feb 25, 2024
5 of 6 checks passed
@charleskawczynski charleskawczynski deleted the ck/rfuse branch February 25, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dennisYatunin dennisYatunin dennisYatunin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charleskawczynski @dennisYatunin