Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

immersion freezing to parcel #244

Merged
merged 1 commit into from
Oct 13, 2023
Merged

immersion freezing to parcel #244

merged 1 commit into from
Oct 13, 2023

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Sep 28, 2023 •
edited
Loading

Purpose

Add immersion freezing to parcel

To-do

  • change x_sulph to some constant, initial mass of soluble h2so4 (actually, gonna put this in a different PR)

Content

  • dust_type option
  • add size distribution options (mono-, gamma, etc.)
  • I have read and checked the items on the review checklist.

@amylu00 amylu00 self-assigned this Sep 28, 2023
This was linked to issues Sep 28, 2023
Integrate homogeneous freezing in the parcel model #183
Closed
Integrate immersion freezing in the parcel model #184
Closed
@codecov
Copy link

codecov bot commented Sep 28, 2023 •
edited
Loading

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (8546e18) 94.56% compared to head (456a3e4) 94.56%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   94.56%   94.56%           
=======================================
  Files          18       18           
  Lines         938      938           
=======================================
  Hits          887      887           
  Misses         51       51

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amylu00 amylu00 changed the title ABIFM & homog freezing to parcel immersion freezing to parcel Sep 28, 2023
@amylu00 amylu00 removed a link to an issue Sep 28, 2023
Integrate homogeneous freezing in the parcel model #183
Closed
@amylu00 amylu00 requested a review from trontrytel September 29, 2023 20:41
@amylu00 amylu00 force-pushed the al/immer_hom_parcel branch from 6078868 to 1424167 Compare October 6, 2023 17:50
@amylu00
Copy link
Member Author

amylu00 commented Oct 6, 2023

bors try

bors bot added a commit that referenced this pull request Oct 6, 2023
@bors
Try #244:
f7745a5
@bors
Copy link
Contributor

bors bot commented Oct 6, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

trontrytel
trontrytel reviewed Oct 12, 2023
View reviewed changes
trontrytel
trontrytel reviewed Oct 12, 2023
View reviewed changes
parcel/parcel.jl Outdated
λ = cbrt(32 * π * N_liq / q_liq * ρ_liq / ρ_air)
#A = N_liq* λ^2
r_l = 2 / λ
A_aer = 4 * π * r_l^2 * N_liq
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here?

@amylu00 amylu00 force-pushed the al/immer_hom_parcel branch from 30a51ab to 456a3e4 Compare October 13, 2023 03:22
@amylu00
Copy link
Member Author

amylu00 commented Oct 13, 2023

bors r+

bors bot added a commit that referenced this pull request Oct 13, 2023
@bors @amylu00
Merge #244
3da4fda 
244: immersion freezing to parcel r=amylu00 a=amylu00



Co-authored-by: amylu00 <alu3@caltech.edu>
@bors
Copy link
Contributor

bors bot commented Oct 13, 2023

Build failed:

@amylu00
Copy link
Member Author

amylu00 commented Oct 13, 2023

bors try

bors bot added a commit that referenced this pull request Oct 13, 2023
@bors
Try #244:
f69ac81
@bors
Copy link
Contributor

bors bot commented Oct 13, 2023

try

Build failed:

@trontrytel
Copy link
Member

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 13, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 6dd4306 into main Oct 13, 2023
@bors bors bot deleted the al/immer_hom_parcel branch October 13, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trontrytel trontrytel trontrytel approved these changes

Assignees

@amylu00 amylu00

Labels
Ice ⛄ Parcel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integrate immersion freezing in the parcel model
2 participants
@amylu00 @trontrytel