Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F_r = 0 exception fixed, mass tests updated #298

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

anastasia-popova
Copy link
Contributor

Purpose

To-do

Content


  • I have read and checked the items on the review checklist.

@anastasia-popova anastasia-popova linked an issue Jan 29, 2024 that may be closed by this pull request
@anastasia-popova anastasia-popova self-assigned this Jan 29, 2024
Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@trontrytel trontrytel marked this pull request as ready for review January 30, 2024 00:21
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa55f4f) 98.69% compared to head (7c25843) 98.69%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          33       33           
  Lines         842      844    +2     
=======================================
+ Hits          831      833    +2     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anastasia-popova anastasia-popova force-pushed the ap/noRime branch 2 times, most recently from 2b105c4 to dc332ec Compare January 30, 2024 18:27
@anastasia-popova anastasia-popova merged commit 6887aac into main Jan 30, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for zero rimed mass and volume
2 participants