Add shape parameters solver for P3 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
==========================================
+ Coverage 98.69% 98.74% +0.04%
==========================================
Files 33 33
Lines 844 874 +30
==========================================
+ Hits 833 863 +30
Misses 11 11 ☔ View full report in Codecov by Sentry. |
trontrytel
force-pushed
the
apaj/shape_params_solver
branch
4 times, most recently
from
1984ce1 to
c951fa4
Compare
trontrytel
force-pushed
the
apaj/shape_params_solver
branch
from
c951fa4 to
2bcf7ec
Compare
trontrytel
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds shape parameters solver to the P3 scheme.
Right now it only works for Float64. We need to switch to different units inside the solver. We should also test the range of input parameters for which the solver converges.