adding activity based dep to parcel #300

amylu00 · 2024-01-30T23:40:54Z

Purpose

To-do

Content

sanity check for correct parameterization of J in docs
add water based deposition nucleation to parcel
compare water based dep with mohler's method in Deposition_Nucleation.jl

I have read and checked the items on the review checklist.

codecov · 2024-01-31T00:07:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11fd264) 98.66% compared to head (3b31672) 98.66%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #300   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          33       33           
  Lines        1047     1047           
=======================================
  Hits         1033     1033           
  Misses         14       14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/src/IceNucleationParcel0D.md

trontrytel · 2024-02-14T05:18:08Z

parcel/parcel.jl

+    if "ActivityBasedDeposition" in ice_nucleation_modes
+        Δa_w = CMO.a_w_eT(tps, e, T) - CMO.a_w_ice(tps, T)
+        J_deposition = CMI_het.deposition_J(aerosol, Δa_w)
+        if "Monodisperse" in droplet_size_distribution


Maybe we should add some error or at least warning that we don't support any other distribution type here?

Yeah that's a good idea. Do you think it's ok to have a printed statement or should we have a hard @assert? I can also open an issue to add more size distributions to some of the freezing modes

I think its ok to just add warnings, or whatever is the easiest. We will refactor parcel soon anyway.

trontrytel · 2024-02-14T05:22:56Z

parcel/parcel.jl

@@ -99,6 +99,15 @@ function parcel_model(dY, Y, p, t)
        end
        dqi_dt_new_depo = dN_act_dt_depo * 4 / 3 * FT(π) * r_nuc^3 * ρ_ice / ρ_air
    end
+    if "ActivityBasedDeposition" in ice_nucleation_modes


I think we are assuming here that someone will either run with MohlerAF MohlerRate or ActivityBased because each time we are doing dqi_dt_new_depo = ... and dN_act_dt_depo = ... instead of +=. I think thats fine, but maybe we could add some error warning to highlight that.

I think because the aerosol types don't overlap between Mohler and Activity based, one could try to run both at the same time

parcel/Deposition_Nucleation.jl

docs/src/plots/activity_based_deposition.jl

trontrytel

Looks great! Thank you for adding the plots with comparisons.

Apologies for merging the parameters update before this. Lmk if there is any friction with it from the package manager

amylu00 added Ice ⛄ Parcel labels Jan 30, 2024

amylu00 self-assigned this Jan 30, 2024

amylu00 force-pushed the al/dep_to_parc branch from be325c0 to 12b9ad6 Compare January 30, 2024 23:48

amylu00 force-pushed the al/dep_to_parc branch 2 times, most recently from 00aa944 to aa4c9ea Compare January 31, 2024 23:14

This was linked to issues Feb 1, 2024

Use droplets for immersion freezing in parcel #278

Closed

Add water activity based dust deposition parameterization #308

Closed

amylu00 force-pushed the al/dep_to_parc branch 3 times, most recently from 9666aca to 63c21c1 Compare February 13, 2024 00:20

amylu00 requested a review from trontrytel February 13, 2024 00:20

trontrytel added the needs review label Feb 13, 2024

amylu00 force-pushed the al/dep_to_parc branch 2 times, most recently from 7bf7173 to d423664 Compare February 13, 2024 00:27