-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup in the landing page and docs #302
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 33 33
Lines 874 874
=======================================
Hits 863 863
Misses 11 11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm replacing the dust_activated_number_fraction
function with one that calculates the rate. If you want to leave it in for now, I can always edit that part of the guides myself after I actually finish making the new function. Otherwise, I'm just being nit-picky about spelling and grammar :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! If only we could find the time to do this for atmos...
One last nitpick - the first paragraph that potential users see is quite long and could be split into 2 smaller ones.
0e4b368
to
d0fa3a5
Compare
d0fa3a5
to
49c4864
Compare
Thank you for all the feedback. I revamped the landing page a little bit more. Let me know if you have any other suggestions |
No description provided.