Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup in the landing page and docs #302

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Cleanup in the landing page and docs #302

merged 1 commit into from
Feb 3, 2024

Conversation

trontrytel
Copy link
Member

No description provided.

@trontrytel trontrytel self-assigned this Feb 1, 2024
@trontrytel trontrytel added the documentation Improvements or additions to documentation label Feb 1, 2024
@trontrytel trontrytel linked an issue Feb 1, 2024 that may be closed by this pull request
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82f0e1d) 98.74% compared to head (49c4864) 98.74%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #302   +/-   ##
=======================================
  Coverage   98.74%   98.74%           
=======================================
  Files          33       33           
  Lines         874      874           
=======================================
  Hits          863      863           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trontrytel trontrytel marked this pull request as ready for review February 2, 2024 01:28
Copy link
Member

@amylu00 amylu00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm replacing the dust_activated_number_fraction function with one that calculates the rate. If you want to leave it in for now, I can always edit that part of the guides myself after I actually finish making the new function. Otherwise, I'm just being nit-picky about spelling and grammar :)

Copy link
Member

@nefrathenrici nefrathenrici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! If only we could find the time to do this for atmos...

One last nitpick - the first paragraph that potential users see is quite long and could be split into 2 smaller ones.

@trontrytel
Copy link
Member Author

Thank you for all the feedback. I revamped the landing page a little bit more. Let me know if you have any other suggestions

@trontrytel trontrytel merged commit 67a8ee7 into main Feb 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the github landing page
4 participants