replacing Mohler AF with nucleation rate

[amylu00]

Purpose

• replacing the AF parameterization from Mohler with the nucleation rate parameterization from the same paper. This requires one less empirical parameter and would be more numerically stable in the parcel model.

To-do

• clean up? delete AF function or replace with a function that calculates the rate. also delete unnecessary parameters (see CLIMAParameters.jl)
• if replacing AF function with new function for rate, revise unit/gpu/performance tests, api, etc.
• fix Tully; the jump between GCM time steps should cause a jump in ice formation

Content

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (06aac2d) 98.66% compared to head (6d7a331) 98.66%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          33       33           
  Lines        1045     1046    +1     
=======================================
+ Hits         1031     1032    +1     
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[trontrytel]

Thank you!