-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
P3 ice nucleation parameterizations #305
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #305 +/- ##
==========================================
+ Coverage 98.68% 98.71% +0.02%
==========================================
Files 33 33
Lines 1068 1088 +20
==========================================
+ Hits 1054 1074 +20
Misses 14 14 ☔ View full report in Codecov by Sentry. |
3a88bb8
to
2ffea8d
Compare
240abae
to
22de61b
Compare
fd0e3fa
to
977a4a8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for doing this! I left some minor comments.
It would be nice to move the free parameters of those schemes to CLIMAParameters, but I can do it later
6d85503
to
a35f8c6
Compare
9c9046a
to
2a2d62f
Compare
Purpose
To-do
Content