Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P3 ice nucleation parameterizations #305

Merged
merged 1 commit into from
Feb 17, 2024
Merged

P3 ice nucleation parameterizations #305

merged 1 commit into from
Feb 17, 2024

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Feb 2, 2024

Purpose

To-do

  • compare to our ice nucleation parameterizations in separate PR?

Content

  • added P3 heterogeneous ice nucleation parameterizations in IceNucleation.jl
  • add p3 options to parcel
  • make pretty plots to test it out
  • add implementation in parcel and plots to documentation

@amylu00 amylu00 added the Ice ⛄ label Feb 2, 2024
@amylu00 amylu00 self-assigned this Feb 2, 2024
Copy link

codecov bot commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c353428) 98.68% compared to head (2a2d62f) 98.71%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #305      +/-   ##
==========================================
+ Coverage   98.68%   98.71%   +0.02%     
==========================================
  Files          33       33              
  Lines        1068     1088      +20     
==========================================
+ Hits         1054     1074      +20     
  Misses         14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amylu00 amylu00 force-pushed the al/p3_ice_nuc branch 4 times, most recently from 3a88bb8 to 2ffea8d Compare February 8, 2024 23:50
@amylu00 amylu00 force-pushed the al/p3_ice_nuc branch 4 times, most recently from 240abae to 22de61b Compare February 15, 2024 23:02
@amylu00 amylu00 requested a review from trontrytel February 15, 2024 23:02
@trontrytel trontrytel self-requested a review February 16, 2024 07:53
Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for doing this! I left some minor comments.

It would be nice to move the free parameters of those schemes to CLIMAParameters, but I can do it later

@amylu00 amylu00 force-pushed the al/p3_ice_nuc branch 2 times, most recently from 6d85503 to a35f8c6 Compare February 16, 2024 21:15
@amylu00 amylu00 merged commit 4ed2fb1 into main Feb 17, 2024
10 checks passed
@amylu00 amylu00 deleted the al/p3_ice_nuc branch October 22, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants