box tracks droplet radius instead of area #313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #313 +/- ##
=======================================
Coverage 98.74% 98.74%
=======================================
Files 33 33
Lines 875 875
=======================================
Hits 864 864
Misses 11 11 ☔ View full report in Codecov by Sentry. |
amylu00
force-pushed
the
al/generalize_box
branch
from
f13e53c to
5a3dec7
Compare
|
@amylu00 - should we close this one for now? |
amylu00
force-pushed
the
al/generalize_box
branch
from
5a3dec7 to
37526ee
Compare
I'll keep the changes for the constant area box problem and just use that one for testing P3/CM.jl ice nucleation functions |
amylu00
force-pushed
the
al/generalize_box
branch
from
a84e807 to
2a74144
Compare
amylu00
force-pushed
the
al/generalize_box
branch
from
786bb20 to
ff819fc
Compare
amylu00
force-pushed
the
al/generalize_box
branch
from
076636a to
8a54570
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Generalize box model with individual droplet radius in state vector instead of total surface area
To-do
Content