-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aerosol activation NN #318
Conversation
ffdd7fb
to
86648c9
Compare
85621bf
to
96e862d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about the MLJ/Flux specifics, but this looks like a good working start.
A stretch goal might be to get rid of DataFrames as a dependency, I am not sure it is necessary
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
==========================================
- Coverage 98.65% 98.11% -0.55%
==========================================
Files 33 35 +2
Lines 1117 1165 +48
==========================================
+ Hits 1102 1143 +41
- Misses 15 22 +7 ☔ View full report in Codecov by Sentry. |
I have applied all the comments. Thank you @nefrathenrici for all the help with the extensions. Every now and then I get this warning when training the NN. Do you see where the
|
a3d4ab7
to
3be25db
Compare
Seems like codecov gets confused about the code inside the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I think DataFrames really shouldn't be needed here, I can try and remove it when I find the time next week.
I think the Codecov just ignores extensions, I have not been able to find any way around it.
Thanks! That would be great, if you have the time.
So sad. I'm worried my codecov stats will suffer and I will not be able to brag about test coverage anymore. Could we open an issue somewhere on the intercept of codecov and julia extensions communities (assuming it's not empty)... |
72b6c1f
to
ff5d5cf
Compare
ff5d5cf
to
d38910d
Compare
This PR brings in the first part of the work of @mikhailmints from last year SURF. It:
N_activated_per_mode
that will be available if the user has the following packages:DataFrames
,Flux
,MLJ
,MLJFlux
,CSV
,DataFramesMeta
,MLJModels
DataFrames
? But lets refactor that once we have all models working first.)If the
jls
file with the NN model already exists the training is skipped.