Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the docs compile time back to reasonable.
112.712372 seconds (1.54 G allocations: 72.581 GiB, 5.14% gc time, 36.17% compilation time: 8% of which was recompilation)
on my laptop. The reason for the slowdown was setting a very demanding tolerances for the ODE solver in our parcel model (especially if running withFloat64
precision). I think by default we should run everything inFloat32
Btw, when I was running individual simulations I noticed some of them were throwing warnings like:
WARNING: Multiple deposition nucleation parameterizations chosen to run in one simulation. Parcel will only run MohlerAF_Deposition for now.
Is that expected behavior @amylu00 ?