Add ML calibrated ARG2000 parameters #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trontrytel
force-pushed
the
aj/arg_params
branch
2 times, most recently
from
51c1f7f to
efe797a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 33 33
Lines 1047 1047
=======================================
Hits 1033 1033
Misses 14 14 ☔ View full report in Codecov by Sentry. |
nefrathenrici
approved these changes
Feb 15, 2024
src/parameters/toml/ARG2000.toml
Outdated
Comment on lines
1
to
4
| [ARG2000_f_coeff_1] | ||
| value = 0.26583888195264627 | ||
| type = "float" | ||
| description = "Scaling coefficient for an empirically determined functional dependence in Abdul-Razzak and Ghan, 2000. Unitless. DOI: https://doi.org/10.1029/1999JD901161" |
There was a problem hiding this comment.
Now only the new value is required for overrides. Up to you!
Suggested change
| [ARG2000_f_coeff_1] | |
| value = 0.26583888195264627 | |
| type = "float" | |
| description = "Scaling coefficient for an empirically determined functional dependence in Abdul-Razzak and Ghan, 2000. Unitless. DOI: https://doi.org/10.1029/1999JD901161" | |
| [ARG2000_f_coeff_1] | |
| value = 0.26583888195264627 |
There was a problem hiding this comment.
Thats great. I like the short version. We shouldn't duplicate places where we define things.
trontrytel
force-pushed
the
aj/arg_params
branch
from
efe797a to
42e8c97
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the PySDM calibrated parameters to a toml file that we can use if we want to overwrite the default values. I add the overwritten option to some of the tests.