Clean up parameter changes #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefrathenrici
force-pushed
the
ne/hotfix
branch
2 times, most recently
from
b256762 to
1d7579c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 98.67% 98.68%
=======================================
Files 33 33
Lines 1060 1068 +8
=======================================
+ Hits 1046 1054 +8
Misses 14 14 ☔ View full report in Codecov by Sentry. |
trontrytel
approved these changes
Feb 16, 2024
|
@trontrytel We could make a patch release, but it's not urgent since the functionality is the same. |
nefrathenrici
force-pushed
the
ne/hotfix
branch
from
50d3dba to
c353428
Compare
|
Maybe I'll do a patch release before I update the kinematic model dependencies. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I missed changing a few constructors in #315.
This PR changes the following structs to have separate FT and toml dict based constructors:
This is not strictly needed since no functionality is changed but I want to standardize the parameter constructors across repos.