-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parcel model with "rainbow" ice nucleation from Frostenberg et al 2023 #328
Conversation
3b36e5f
to
f04f5ff
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
=======================================
Coverage 96.18% 96.19%
=======================================
Files 36 36
Lines 1233 1234 +1
=======================================
+ Hits 1186 1187 +1
Misses 47 47 ☔ View full report in Codecov by Sentry. |
I left some comments on the draft already. Aside from them, could you also add a small entry to the documentation page with parcel model examples? Including the notes I have in PR 336 and including the plot with the parcel model results. Thank you, this is a really cool example! |
868bb5f
to
5fe902d
Compare
aeeb883
to
2e3f96c
Compare
Here is the final version (I think). Initially I wrote the equations wrong, thinking Now we see that for large gammas (i.e. short assumed timescales) the solution converges to the mean solution. I'm not sure if I understand why we converge to the mean when we draw less frequently in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for future implementation: https://github.com/SciML/StochasticDiffEq.jl |
1607cc3
to
a7bde12
Compare
8c2715d
to
f558dca
Compare
f558dca
to
115a36c
Compare
Purpose
Add a parcel model example that uses the "rainbow" parameterization the way it was described in Frostenberg et al 2023 . Test the dependency on dt, drawing frequency, etc.
To-do
Content