Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parcel model with "rainbow" ice nucleation from Frostenberg et al 2023 #328

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

AgnieszkaMakulska
Copy link
Contributor

@AgnieszkaMakulska AgnieszkaMakulska commented Feb 18, 2024

Purpose

Add a parcel model example that uses the "rainbow" parameterization the way it was described in Frostenberg et al 2023 . Test the dependency on dt, drawing frequency, etc.

To-do

Content


  • I have read and checked the items on the review checklist.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.19%. Comparing base (d9acd62) to head (115a36c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #328   +/-   ##
=======================================
  Coverage   96.18%   96.19%           
=======================================
  Files          36       36           
  Lines        1233     1234    +1     
=======================================
+ Hits         1186     1187    +1     
  Misses         47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trontrytel
Copy link
Member

I left some comments on the draft already. Aside from them, could you also add a small entry to the documentation page with parcel model examples? Including the notes I have in PR 336 and including the plot with the parcel model results. Thank you, this is a really cool example!

@trontrytel trontrytel mentioned this pull request Feb 29, 2024
1 task
@trontrytel trontrytel force-pushed the am/parcel_model_ice branch from aeeb883 to 2e3f96c Compare March 1, 2024 00:22
@trontrytel trontrytel added enhancement New feature or request needs review and removed work-in-progress labels Mar 1, 2024
@trontrytel trontrytel self-assigned this Mar 1, 2024
@trontrytel trontrytel requested a review from haakon-e March 1, 2024 00:24
@trontrytel trontrytel marked this pull request as ready for review March 1, 2024 00:24
@trontrytel
Copy link
Member

trontrytel commented Mar 1, 2024

Here is the final version (I think). Initially I wrote the equations wrong, thinking g = sigma sqrt(2 gamma) But that actually gives us the wrong limit and the noise in the system does not increase as we change the gamma scale. It should be g = sigma (duh...)

Now we see that for large gammas (i.e. short assumed timescales) the solution converges to the mean solution.

I'm not sure if I understand why we converge to the mean when we draw less frequently in the random option (dotted lines)

Screenshot 2024-02-29 at 4 30 36 PM

@trontrytel
Copy link
Member

I cleaned up some of the names in the example. Not sure what is the least confusing way of naming/specifying the sampling interval in the random scheme. But at least now on the labels we have the same units (i.e. either the time between sampling in the random case or the assumed process time scale in the stochastic case). The problem is that even if the units are the same the interpretation is the opposite (I think). The larger sampling interval the more close we are to the mean. But the shorter the time scale the closer we are to the mean.

Below I show two plots with the same assumed sampling intervals and timescales, but different model dt of either 0.1s or 1s. It would be better to plot everything on one plot, but I'm thinking how to do it neatly.

Screenshot 2024-02-29 at 8 10 07 PM Screenshot 2024-02-29 at 8 10 20 PM

@trontrytel
Copy link
Member

Yet another attempt at squeezing in more plots:
Screenshot 2024-02-29 at 10 12 56 PM

Copy link
Member

@haakon-e haakon-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haakon-e
Copy link
Member

haakon-e commented Mar 4, 2024

for future implementation: https://github.com/SciML/StochasticDiffEq.jl

@trontrytel trontrytel force-pushed the am/parcel_model_ice branch 3 times, most recently from 1607cc3 to a7bde12 Compare March 14, 2024 20:20
@trontrytel trontrytel force-pushed the am/parcel_model_ice branch 2 times, most recently from 8c2715d to f558dca Compare March 14, 2024 20:25
@trontrytel trontrytel force-pushed the am/parcel_model_ice branch from f558dca to 115a36c Compare March 14, 2024 20:54
@trontrytel trontrytel enabled auto-merge March 14, 2024 20:54
@trontrytel trontrytel merged commit 2e02492 into main Mar 14, 2024
10 checks passed
@haakon-e haakon-e mentioned this pull request Mar 15, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants