Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comparing activity based IN with P3 IN #330

Merged
merged 2 commits into from
Feb 28, 2024
Merged

comparing activity based IN with P3 IN #330

merged 2 commits into from
Feb 28, 2024

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Feb 19, 2024

Purpose

To-do

Content

  • add example where activity based parameterizations are compared to P3 ice nucleation parameterizations
  • add to documentation

  • I have read and checked the items on the review checklist.

@amylu00 amylu00 self-assigned this Feb 19, 2024
Copy link

codecov bot commented Feb 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.72%. Comparing base (9c4a336) to head (11a7b9b).
Report is 1 commits behind head on main.

❗ Current head 11a7b9b differs from pull request most recent head b5c84f0. Consider uploading reports for the commit b5c84f0 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #330   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          33       33           
  Lines        1101     1101           
=======================================
  Hits         1087     1087           
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amylu00
Copy link
Member Author

amylu00 commented Feb 27, 2024

Final product:
P3_vs_activitybased

@amylu00 amylu00 force-pushed the al/p3_comparison branch 2 times, most recently from 7e30849 to 8e4c940 Compare February 27, 2024 21:15
@amylu00 amylu00 requested a review from trontrytel February 27, 2024 21:15
@amylu00 amylu00 force-pushed the al/p3_comparison branch 2 times, most recently from 297ecc6 to 11a7b9b Compare February 27, 2024 23:19
@trontrytel trontrytel self-requested a review February 28, 2024 04:00
Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left some minor comments.

Glad to see it all come together and looking forward to the calibration setups

@amylu00 amylu00 enabled auto-merge February 28, 2024 20:43
@amylu00 amylu00 merged commit e871fef into main Feb 28, 2024
8 checks passed
@amylu00 amylu00 deleted the al/p3_comparison branch October 22, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants