Update to ClimaParams v0.10 #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nefrathenrici
force-pushed
the
ne/update_cp
branch
from
f00a213 to
9901798
Compare
|
Wow, I think you are going for the "Most files modified in all CliMA stack per week" award :) |
Turns out that CLIMAParameters was widely used, who knew! |
nefrathenrici
force-pushed
the
ne/update_cp
branch
from
9901798 to
dee6a64
Compare
nefrathenrici
force-pushed
the
ne/update_cp
branch
from
dee6a64 to
ef80b76
Compare
nefrathenrici
force-pushed
the
ne/update_cp
branch
from
ef80b76 to
c9ac023
Compare
|
I would like to merge this PR before: #341 Also, could we make it a breaking release? |
nefrathenrici
force-pushed
the
ne/update_cp
branch
from
c9ac023 to
f9e04dd
Compare
trontrytel
reviewed
Feb 28, 2024
trontrytel
approved these changes
Feb 28, 2024
nefrathenrici
force-pushed
the
ne/update_cp
branch
from
f9e04dd to
a4f9ec3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
=======================================
Coverage 98.72% 98.72%
=======================================
Files 33 33
Lines 1101 1101
=======================================
Hits 1087 1087
Misses 14 14 ☔ View full report in Codecov by Sentry. |
nefrathenrici
force-pushed
the
ne/update_cp
branch
from
a4f9ec3 to
ce64d4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates to the new package once it has been released. Depends on Thermodynamics releasing a new patch version first.