Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linear HOM J option #366

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Linear HOM J option #366

merged 1 commit into from
Apr 15, 2024

Conversation

amylu00
Copy link
Member

@amylu00 amylu00 commented Apr 8, 2024

Purpose

To-do

Content

  • create linear parameterization for homogeneous ice nucleation rate coefficient J dependent on water activity criterion

  • I have read and checked the items on the review checklist.

@amylu00 amylu00 added the Ice ⛄ label Apr 8, 2024
@amylu00 amylu00 self-assigned this Apr 8, 2024
Copy link

codecov bot commented Apr 13, 2024

Codecov Report

Merging #366 (17a1572) into main (62327bb) will increase coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #366      +/-   ##
==========================================
+ Coverage   94.83%   94.84%   +0.01%     
==========================================
  Files          36       36              
  Lines        1258     1261       +3     
==========================================
+ Hits         1193     1196       +3     
  Misses         65       65              
Components Coverage Δ
src 99.29% <100.00%> (+<0.01%) ⬆️
ext 54.40% <ø> (ø)

Copy link
Member

@trontrytel trontrytel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@amylu00 amylu00 merged commit 5da62fb into main Apr 15, 2024
12 checks passed
@amylu00 amylu00 deleted the al/linear_HOM branch October 22, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants