Add terminal velocities to P3 scheme #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
- Coverage 94.95% 94.89% -0.07%
==========================================
Files 36 36
Lines 1288 1370 +82
==========================================
+ Hits 1223 1300 +77
- Misses 65 70 +5
|
trontrytel
force-pushed
the
apaj/p3_termVel
branch
from
f2c5236 to
1c9b870
Compare
trontrytel
force-pushed
the
apaj/p3_termVel
branch
2 times, most recently
from
b89e85f to
6004129
Compare
trontrytel
force-pushed
the
apaj/p3_termVel
branch
from
6004129 to
0945be5
Compare
anastasia-popova
approved these changes
Apr 19, 2024
trontrytel
force-pushed
the
apaj/p3_termVel
branch
from
0945be5 to
ca4357b
Compare
nefrathenrici
approved these changes
Apr 19, 2024
| Cloudy = "0.4" | ||
| DataFrames = "1.6" | ||
| DocStringExtensions = "0.8, 0.9" | ||
| EnsembleKalmanProcesses = "1.1.5" | ||
| ForwardDiff = "0.10" | ||
| MLJ = "0.20" | ||
| QuadGK = "2.9.4" |
There was a problem hiding this comment.
Does the compat need to be so precise?
There was a problem hiding this comment.
Probably not. - Lets see!
|
|
||
| Integrates f(D, c1, c2, c3) dD from x₀ to x_end | ||
| """ | ||
| function ∫_Γ(x₀::FT, x_end::FT, c1::FT, c2::FT, c3::FT) where {FT} |
There was a problem hiding this comment.
This is a great function name!
| @@ -9,6 +9,7 @@ DocumenterCitations = "daee34ce-89f3-4625-b898-19384cb65244" | |||
| Literate = "98b081ad-f1c9-55d3-8b20-4c87d4299306" | |||
| OrdinaryDiffEq = "1dea7af3-3e70-54e6-95c3-0bf5283fa5ed" | |||
| Plots = "91a5bcdd-55d7-5caf-9e0b-520d859cae80" | |||
| QuadGK = "1fd47b50-473d-5c70-9696-f719f8f3bcdc" | |||
There was a problem hiding this comment.
This dependency should only be needed in the main Project.toml, unless you use it in the docs directly. The same applies for the test Project.toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from #334