Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to non-UTF8 string functions with pre-23.8 ClickHouse #227

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

slvrtrn
Copy link
Collaborator

@slvrtrn slvrtrn commented Feb 23, 2024

Summary

Resolves #224.

  • Long changeset due to tests being moved around, split and marked as parallel to speed up the execution (up to 4x on my machine, ~1.5x on CI; that's for ClickHouse driver tests only, obviously).
  • If introspected ClickHouse version is lower than 23.8, the driver will not use startsWithUTF8 and fall back to its non-UTF8 counterpart instead. There is a drawback in this compatibility mode: potentially incorrect filtering results when working with non-latin strings. If your use case includes filtering by columns with such strings and you experience these issues, consider upgrading your ClickHouse server to 23.8+.
  • Added CI with ClickHouse 23.3 (current "LTS") to run at least ClickHouse driver tests. All Metabase tests will be run as usual using the latest version.

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@slvrtrn slvrtrn requested a review from mshustov February 23, 2024 00:15
@slvrtrn slvrtrn merged commit 979a3ac into master Feb 26, 2024
1 check passed
@slvrtrn slvrtrn deleted the string-functions-based-on-version branch February 26, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Column filter "startsWith" defaults to "startsWithUTF8"
2 participants