Refactor: migration: extract a function _migrate_totem_interface (jsc#PED-8252)

Author: nicholasyang2022

crmsh/migration.py

@@ -430,14 +430,7 @@ def migrate_udpu(dom):
     dom['totem']['transport'] = 'knet'
     if 'interface' in dom['totem']:
         for interface in dom['totem']['interface']:
-            # remove udp-only items
-            interface.pop('mcastaddr', None)
-            interface.pop('bindnetaddr', None)
-            interface.pop('broadcast', None)
-            interface.pop('ttl', None)
-            ringnumber = interface.pop('ringnumber', None)
-            if ringnumber is not None:
-                interface['linknumber'] = ringnumber
+            _migrate_totem_interface(interface)
     if 'quorum' in dom:
         dom['quorum'].pop('expected_votes', None)
     logger.info("Upgrade totem.transport to knet.")
@@ -446,14 +439,7 @@ def migrate_udpu(dom):
 def migrate_multicast(dom):
     dom['totem']['transport'] = 'knet'
     for interface in dom['totem']['interface']:
-        # remove udp-only items
-        interface.pop('mcastaddr', None)
-        interface.pop('bindnetaddr', None)
-        interface.pop('broadcast', None)
-        interface.pop('ttl', None)
-        ringnumber = interface.pop('ringnumber', None)
-        if ringnumber is not None:
-            interface['linknumber'] = ringnumber
+        _migrate_totem_interface(interface)
     logger.info("Generating nodelist according to CIB...")
     with open(constants.CIB_RAW_FILE, 'rb') as f:
         cib = lxml.etree.parse(f)
@@ -490,6 +476,17 @@ def migrate_multicast(dom):
     logger.info("Upgrade totem.transport to knet.")
 
 
+def _migrate_totem_interface(interface):
+    # remove udp-only items
+    interface.pop('mcastaddr', None)
+    interface.pop('bindnetaddr', None)
+    interface.pop('broadcast', None)
+    interface.pop('ttl', None)
+    ringnumber = interface.pop('ringnumber', None)
+    if ringnumber is not None:
+        interface['linknumber'] = ringnumber
+
+
 class _BindnetaddrFixer:
     # crmsh generates incorrect bindnetaddr when joining a corosync 2 multicast cluster
     def __init__(self, interfaces: typing.Iterable[iproute2.IPInterface]):