Skip to content

Commit 5ab3a5d

Browse files
authored
Dev: coverage: inject coverage with sitecustomize.py in feature tests (#1458)
With python-coverage updated to 7.5.3 from 4.x, code called with `multiprocessing` is able to be measured now. This is an refreshed version of #1297.
2 parents 30a5a20 + 124750c commit 5ab3a5d

File tree

5 files changed

+9
-6
lines changed

5 files changed

+9
-6
lines changed

codecov.yml

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,9 @@ coverage:
66
patch:
77
default:
88
threshold: 0.35%
9-
codecov:
9+
codecov:
1010
notify:
1111
after_n_builds: 27
1212
comment:
1313
after_n_builds: 27
1414
layout: "condensed_header, flags, files, condensed_footer"
15-
16-
ignore:
17-
- "crmsh/report"

data-manifest

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ test/features/cluster_api.feature
7474
test/features/configure_bugs.feature
7575
test/features/constraints_bugs.feature
7676
test/features/corosync_ui.feature
77-
test/features/coveragerc
77+
test/features/coverage/coveragerc
78+
test/features/coverage/sitecustomize.py
7879
test/features/crm_report_bugs.feature
7980
test/features/crm_report_normal.feature
8081
test/features/environment.py
File renamed without changes.
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
import coverage
2+
import atexit
3+
cov=coverage.Coverage(config_file="/opt/crmsh/test/features/coverage/coveragerc")
4+
atexit.register(lambda:(cov.stop(),cov.save()))
5+
cov.start()

test/run-functional-tests

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,7 @@ run_origin_regression_test() {
411411

412412
prepare_coverage_env() {
413413
for node in $*; do
414-
docker exec -t $node /bin/sh -c 'sed -i '\''1a\import coverage\nimport atexit\ncov=coverage.Coverage(config_file="/opt/crmsh/test/features/coveragerc")\natexit.register(lambda:(cov.stop(),cov.save()))\ncov.start()'\'' /usr/sbin/crm'
414+
docker cp "$PROJECT_PATH"/test/features/coverage/sitecustomize.py "$node":/usr/lib/python3.11/site-packages/sitecustomize.py
415415
done
416416
}
417417

0 commit comments

Comments
 (0)