Skip to content

Commit be2154f

Browse files
committed
Dev: bootstrap: Minor refactoring of the get_address_list function
1 parent d0534b9 commit be2154f

File tree

1 file changed

+10
-3
lines changed

1 file changed

+10
-3
lines changed

crmsh/bootstrap.py

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1325,16 +1325,23 @@ def get_address_list() -> typing.List[str]:
13251325
else:
13261326
valid_func = Validation.valid_ucast_ip
13271327

1328+
if _context.yes_to_all:
1329+
loop_count = len(_context.default_ip_list)
1330+
else:
1331+
# non-interative mode
1332+
# will ask for each interface, max is Context.MAX_LINK_NUM
1333+
loop_count = min(Context.MAX_LINK_NUM, len(_context.interfaces_inst.nic_list))
1334+
13281335
ringXaddr_list = []
1329-
loop_count = min(Context.MAX_LINK_NUM, len(_context.default_ip_list))
13301336
for i in range(loop_count):
1337+
# at non-interactive mode, need to confirm after default ip list been consumed
1338+
if i >= len(_context.default_ip_list) and not confirm("\nAdd another ring?"):
1339+
break
13311340
addr = prompt_for_string("Address for ring{}".format(i),
13321341
default=pick_default_value(_context.default_ip_list, ringXaddr_list),
13331342
valid_func=valid_func,
13341343
prev_value=ringXaddr_list)
13351344
ringXaddr_list.append(addr)
1336-
if i < (loop_count - 1) and not confirm("\nAdd another ring?"):
1337-
break
13381345

13391346
return ringXaddr_list
13401347

0 commit comments

Comments
 (0)