Skip to content

Dev: utils: Add info when property is newly added #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented May 6, 2024

case 1

# first node init
no 'priority' property

# then the second node join
set 'priority=1' with no warning/info to show this behavior

case 2

# two-node cluster running
# remove the second node
show:
WARNING: "priority" in rsc_defaults is set to 0, it was 1

case 3

# removed node re-join
show:
WARNING: "priority" in rsc_defaults is set to 1, it was 0

This PR adds info when the property is newly added, for case 1

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.74%. Comparing base (42ad4f1) to head (2bf5106).
Report is 10 commits behind head on master.

Files Patch % Lines
crmsh/utils.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1414      +/-   ##
==========================================
+ Coverage   53.63%   53.74%   +0.10%     
==========================================
  Files          80       80              
  Lines       24081    24059      -22     
==========================================
+ Hits        12917    12931      +14     
+ Misses      11164    11128      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also change line 2803 to use %s instead of {}.

@liangxin1300 liangxin1300 force-pushed the 20240506_show_info_adding_property branch from 5fcecb5 to 007d524 Compare May 8, 2024 10:11
@liangxin1300 liangxin1300 merged commit ea6db17 into ClusterLabs:master May 9, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants