corosync config parser minor changes #1415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1415 +/- ##
==========================================
+ Coverage 53.63% 53.74% +0.10%
==========================================
Files 80 80
Lines 24081 24058 -23
==========================================
+ Hits 12917 12931 +14
+ Misses 11164 11127 -37 ☔ View full report in Codecov by Sentry. |
crmsh/corosync_config_format.py
Outdated
Comment on lines
44
to
45
| fake_secion_name = f'{COMMENT_PREFIX}_{lineno}' | ||
| self.on_key_value(fake_secion_name, tokens[2]) |
There was a problem hiding this comment.
Suggested change
| fake_secion_name = f'{COMMENT_PREFIX}_{lineno}' | |
| self.on_key_value(fake_secion_name, tokens[2]) | |
| fake_key = f'{COMMENT_PREFIX}_{lineno}' | |
| self.on_key_value(fake_key, tokens[2]) |
crmsh/corosync_config_format.py
Outdated
| self.on_value(value) | ||
| self._ofile.write('\n') | ||
| if key.startswith(COMMENT_PREFIX): | ||
| self._ofile.write(f'# {value}\n') |
There was a problem hiding this comment.
Suggested change
| self._ofile.write(f'# {value}\n') | |
| self.__write_indent(len(self._path_stack)) | |
| self._ofile.write('# ') | |
| self._ofile.write(value) | |
| self._ofile.write('\n') |
- Writing to buffered io directly tends to provide better performance.
- Indentation is needed
crmsh/corosync_config_format.py
Outdated
| @@ -8,12 +8,13 @@ | |||
|
|
|||
|
|
|||
| logger = logging.getLogger(__name__) | |||
| COMMENT_PREFIX = '__comment' | |||
There was a problem hiding this comment.
Suggested change
| COMMENT_PREFIX = '__comment' | |
| COMMENT_PREFIX = '#comment' |
Using # will make sure it does not conflict with anything.
liangxin1300
force-pushed
the
20240507_corosync_parser_improve
branch
from
fd2d806 to
258d56e
Compare
Changed |
nicholasyang2022
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add these two lines to the header