interface network option improvement

[liangxin1300]

• Give valid value list for the -i option when the value is invalid

# crm cluster init -i xxx
ERROR: cluster.init: Invalid value 'xxx' for -i/--interface option

# After applying this PR

# crm cluster init -i xxx
ERROR: cluster.init: Invalid value 'xxx' for -i/--interface option, should be enp1s0, enp7s0, enp8s0 or 192.168.122.189, 10.10.10.61, 20.20.20.61

• On join side, adjust the condition of comparing the link number

# on init node
# crm cluster init -i 10.10.10.61 -i 20.20.20.61 -y

# on join node
# crm cluster join
# ...
# ERROR: cluster.join: knet transport of all cluster nodes need 2 links via '-i' options, but provided 1

# After applying this PR

# crm cluster join
# ...
# Address for ring0 [192.168.122.145]
# Address for ring1 []10.10.10.62

• Minor refactoring of the get_address_list function

# no way to add another ring on interactive mode
# crm cluster init
...
Address for ring0 [192.168.122.189]
INFO: Configure SBD:

# After applying this PR
# crm cluster init
...
Address for ring0 [192.168.122.145]

Add another ring (y/n)?

# no need to ask for confirm for each -i option
# crm cluster init -i enp7s0 -i enp8s0
...
Address for ring0 [10.10.10.61]

Add another ring (y/n)?

# After applying this PR
 # crm cluster init -i enp7s0 -i enp8s0
...
Address for ring0 [10.10.10.62]
Address for ring1 [20.20.20.62]
INFO: Configure SBD:

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.74%. Comparing base (ec25d36) to head (1adedcb).
Report is 7 commits behind head on master.

Files	Patch %	Lines
crmsh/bootstrap.py	83.33%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1421      +/-   ##
==========================================
- Coverage   53.74%   53.74%   -0.01%     
==========================================
  Files          80       80              
  Lines       24058    24064       +6     
==========================================
+ Hits        12931    12934       +3     
- Misses      11127    11130       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[nicholasyang2022]

should be ['enp1s0', 'enp7s0', 'enp8s0'] or ['192.168.122.189', '10.10.10.61', '20.20.20.61']

This is confusing. How about

should be 'enp1s0', 'enp7s0', 'enp8s0', '192.168.122.189', '10.10.10.61', or '20.20.20.61'.

[nicholasyang2022]

Should be "at interactive mode"?

[nicholasyang2022]

It does not make sense to ask for another ring when -i is specified in cmdline, especially when multiple -i is specified. Or at least, the question should have a default answer 'N' so that the user can simply skip the question by pressing Enter.

[liangxin1300]

It does not make sense to ask for another ring when -i is specified in cmdline, especially when multiple -i is specified. Or at least, the question should have a default answer 'N' so that the user can simply skip the question by pressing Enter.

Changed, not ask when -i was specified

[nicholasyang2022]

Suggested change

	# interative mode or without -i option specified
	# interative mode and without -i option specified