Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

nicholasyang2022 · 2024-05-16T07:28:52Z

This pull request implements migrating corosync.conf from corosync 2 to corosync 3, including:

migrate deprecated transport udpu and udp to knet
replace removed feature RRP with knet multilink
if crypto_hash is set to sha1, which is the default value in corosync 2, upgrades it to the new default in corosync 3, sha256.

Use Cases

Check When All Green for Migration

> sudo crm cluster health sles16
------ node: localhost ------
[INFO] Checking dependency version...
[INFO] Checking used corosync features...
[WARN] Corosync transport "udpu" will be deprecated in corosync 3. Please use knet.

------ cib ------
[WARN] The CIB is not validated with the latest schema version.
       * Latest version:  3.10
       * Current version: 3.9
[INFO] Checking used resource agents...

------ node: ha-2-2 ------
[WARN] Corosync transport "udpu" will be deprecated in corosync 3. Please use knet.

****** summary ******
[INFO] Please run "crm cluster health sles16 --fix" on on any one of above nodes.
[PASS] This cluster is good to migrate to SLES 16.

Check When Already Migrated

> sudo crm cluster health sles16
------ node: localhost ------
[INFO] Checking dependency version...
[INFO] Checking used corosync features...

------ cib ------
[INFO] Checking used resource agents...

------ node: ha-2-2 ------

****** summary ******
[INFO] This cluster works on SLES 16. No migration is needed.

Run Migration

> sudo crm cluster health sles16 --fix
suse@ha-2-1:~> sudo crm cluster health sles16 --fix
------ node: localhost ------
[INFO] Checking dependency version...
[INFO] Checking used corosync features...
[WARN] Corosync transport "udpu" will be deprecated in corosync 3. Please use knet.

------ cib ------
[WARN] The CIB is not validated with the latest schema version.
       * Latest version:  3.10
       * Current version: 3.9
[INFO] Checking used resource agents...

------ node: ha-2-2 ------
[WARN] Corosync transport "udpu" will be deprecated in corosync 3. Please use knet.

INFO: Starting migration...
INFO: Migrating corosync configuration...
INFO: Upgrade totem.transport to knet.
INFO: Upgrade totem.crypto_hash from "sha1" to "sha256".
INFO: Finish migrating corosync configuration. The original configuration is renamed to corosync.conf.bak
INFO: Finished migration.

Try to Run Migration When Already Migrated

suse@ha-2-1:~> sudo crm cluster health sles16 --fix
------ node: localhost ------
[INFO] Checking dependency version...
[INFO] Checking used corosync features...

------ cib ------
[WARN] The CIB is not validated with the latest schema version.
       * Latest version:  3.10
       * Current version: 3.9
[INFO] Checking used resource agents...

------ node: ha-2-2 ------

INFO: This cluster works on SLES 16 with some warnings. Please fix the remaining warnings manually.

codecov · 2024-05-16T07:50:04Z

Codecov Report

Attention: Patch coverage is 82.65896% with 90 lines in your changes missing coverage. Please review.

Project coverage is 69.97%. Comparing base (0f77021) to head (2c7b93f).
Report is 49 commits behind head on master.

Files with missing lines	Patch %	Lines
crmsh/migration.py	82.37%	77 Missing ⚠️
crmsh/ui_cluster.py	73.68%	10 Missing ⚠️
crmsh/cibquery.py	90.00%	3 Missing ⚠️

Additional details and impacted files

Flag	Coverage Δ
integration	`54.16% <82.08%> (+0.55%)`	⬆️
unit	`52.61% <27.36%> (-0.48%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
crmsh/corosync.py	`87.64% <100.00%> (ø)`
crmsh/prun/runner.py	`64.86% <100.00%> (+0.97%)`	⬆️
crmsh/sh.py	`92.50% <ø> (+0.41%)`	⬆️
crmsh/utils.py	`66.33% <100.00%> (-0.16%)`	⬇️
crmsh/xmlutil.py	`69.24% <100.00%> (+0.03%)`	⬆️
crmsh/cibquery.py	`90.00% <90.00%> (ø)`
crmsh/ui_cluster.py	`74.81% <73.68%> (-0.63%)`	⬇️
crmsh/migration.py	`82.37% <82.37%> (ø)`

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

liangxin1300 · 2025-01-03T08:06:32Z

In

# crm cluster health sles16
------ localhost ------
[INFO] Checking dependency version...
[FAIL] Pacemaker version not supported
       Supported version: 3 <= Pacemaker
       Actual version:    Pacemaker == 2.1.9

Supported version: 3 <= Pacemaker better changed similar as Supported version: Pacemaker >= 3

liangxin1300 · 2025-01-03T08:23:52Z

# crm cluster health sles16
------ localhost ------
[INFO] Checking dependency version...
[FAIL] Pacemaker version not supported
       Supported version: 3 <= Pacemaker
       Actual version:    Pacemaker == 2.1.9
[INFO] Checking service status...
[FAIL] Cluster services are running
       * corosync
       * pacemaker
[INFO] Checking used corosync features...

------ alp-3 ------



------ alp-2 ------

No output for remote nodes

zzhou1 · 2025-01-06T06:05:06Z

[FAIL] Cluster services are running
* corosync
* pacemaker

FAIL as the fatal error sounds too strong to me.

No matter it is corosync2 or corosync3 environment, nothing wrong to run crm cluster health sles16 no matter the cluster is running or not.

(cherry picked from commit 3264f0d)

(cherry picked from commit e656662)

…c#PED-11808) (cherry picked from commit 72cd46f)

(cherry picked from commit 54def35)

…jsc#PED-11808) (cherry picked from commit 7bf54e9)

(cherry picked from commit 84143c4)

…PED-11808) should use recursive queries (cherry picked from commit 4b7e42d)

…ilesystem_with_fstype (cherry picked from commit 48aca45)

(cherry picked from commit 1e48317)

(cherry picked from commit 97fa52b)

as it is not a hard requirement to upgrade pacemaker 2 to 3.

…252)

…ed with `--fix` (jsc#PED-8252)

…jsc#PED-8252) * should not run the migration if already migrated * should not tell users to run `crm cluster health sles16 --fix` if already migrated

so that we can report an error without blocking migration.

…PED-8252) No matter the cluster is running or not, there is nothing wrong to run the check or fix.

… some non-fatal problems which need manual fix (jsc#PED-8252) also refactor the return code of _check_impl()

…n (jsc#PED-8252)

…8252)

…cluster (jsc#PED-8252) crmsh generates incorrect bindnetaddr when joining a corosync 2 multicast cluster. This should be fixed before used in nodelist.

…ide effects (jsc#PED-8252)

…#PED-8252)

liangxin1300

Great work
Thanks!

nicholasyang2022 force-pushed the ped-8252-20240516 branch 5 times, most recently from 3c620cf to 2d4c6db Compare May 27, 2024 08:05

nicholasyang2022 force-pushed the ped-8252-20240516 branch 2 times, most recently from fdcdc65 to c6cd605 Compare October 23, 2024 03:52

nicholasyang2022 force-pushed the ped-8252-20240516 branch 3 times, most recently from 04ea10f to 69020cc Compare November 1, 2024 04:21

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 69020cc to ab808d1 Compare December 13, 2024 08:00

nicholasyang2022 force-pushed the ped-8252-20240516 branch 5 times, most recently from fa10732 to 68bd445 Compare January 2, 2025 09:14

liangxin1300 mentioned this pull request Jan 3, 2025

[crmsh-4.6] Dev: pre-migration: implement pre-migration checks for SLES 16 (jsc#PED-11808) #1629

Merged

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 68bd445 to 389d007 Compare January 6, 2025 04:54

nicholasyang2022 force-pushed the ped-8252-20240516 branch 2 times, most recently from 486020b to 16cd739 Compare January 23, 2025 07:31

nicholasyang2022 force-pushed the ped-8252-20240516 branch 6 times, most recently from 9e1b95b to 38d9896 Compare February 13, 2025 03:18

nicholasyang2022 added 24 commits March 7, 2025 16:33

Dev: add pre-migration checks for pacemaker version (jsc#PED-11808)

e7cb83a

(cherry picked from commit 3264f0d)

Dev: pre-migration: do not colorize hostname header (jsc#PED-11808)

b995f40

(cherry picked from commit e656662)

Dev: pre-migration: add completer for 'crm cluster health sles16' (js…

4a80940

…c#PED-11808) (cherry picked from commit 72cd46f)

Fix: ui_cluster: fix do_health usage output

43f05d1

(cherry picked from commit 54def35)

Dev: pre-migration: add message about removing stonith:external/sbd (…

9dd577c

…jsc#PED-11808) (cherry picked from commit 7bf54e9)

Doc: ui_cluster: add document for crm cluster health hawk2|sles16

afc701f

(cherry picked from commit 84143c4)

Fix: cibquery: grouped primitives is missing from query results (jsc#…

5489382

…PED-11808) should use recursive queries (cherry picked from commit 4b7e42d)

Refactor: cibquery: has_primitive_filesystem_ocfs2 to has_primitive_f…

c77a179

…ilesystem_with_fstype (cherry picked from commit 48aca45)

Dev: pre-migration: add summary section to output (jsc#PED-11808)

10f2155

(cherry picked from commit 1e48317)

Dev: migration: refine message wording (jsc#PED-11808)

f95b050

(cherry picked from commit 97fa52b)

Dev: migration: do not check pacemaker version (jsc#PED-8252)

dd53f1d

as it is not a hard requirement to upgrade pacemaker 2 to 3.

Dev: behave: add functional tests for pre-migration checks (jsc#PED-8…

0108812

…252)

Fix: migration: should not show pre-migration check summary when call…

375ced4

…ed with `--fix` (jsc#PED-8252)

Dev: migration: check if the cluster is already migrated to SLES 16 (…

d0ab681

…jsc#PED-8252) * should not run the migration if already migrated * should not tell users to run `crm cluster health sles16 --fix` if already migrated

Dev: migration: split problem level and is_blocker (jsc#PED-8252)

06549a9

so that we can report an error without blocking migration.

Dev: migration: add a checker for cib schema version (jsc#PED-8252)

86c65b3

Dev: migration: no need to check if cluster services is stopped (jsc#…

cbf0c48

…PED-8252) No matter the cluster is running or not, there is nothing wrong to run the check or fix.

Fix: migration: should not report need migration when the cluster has…

6b50f7b

… some non-fatal problems which need manual fix (jsc#PED-8252) also refactor the return code of _check_impl()

Dev: migration: add a message about corosync.conf.bak (jsc#PED-82582)

7a112fa

Dev: migration: refine the message about unsupported component versio…

249058d

…n (jsc#PED-8252)

Fix: migration: IndexError when there is only one interface (jsc#PED-…

e7859cc

…8252)

Dev: migration: fix incorrect bindnetaddr when migrating a multicast …

5e15450

…cluster (jsc#PED-8252) crmsh generates incorrect bindnetaddr when joining a corosync 2 multicast cluster. This should be fixed before used in nodelist.

Refactor: cibquery: extract a function to get cluster nodes without s…

edc97d1

…ide effects (jsc#PED-8252)

Refactor: migration: extract a function _migrate_totem_interface (jsc…

e73323d

…#PED-8252)

nicholasyang2022 force-pushed the ped-8252-20240516 branch from 5328fc2 to e73323d Compare March 7, 2025 08:41

liangxin1300 approved these changes Mar 7, 2025

View reviewed changes

Dev: migration: minor refines in message wording

2c7b93f

zzhou1 approved these changes Mar 12, 2025

View reviewed changes

liangxin1300 merged commit ee7aaf4 into ClusterLabs:master Mar 12, 2025
33 checks passed

nicholasyang2022 deleted the ped-8252-20240516 branch May 9, 2025 05:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

Uh oh!

nicholasyang2022 commented May 16, 2024 •

edited

Loading

Uh oh!

codecov bot commented May 16, 2024 •

edited

Loading

Uh oh!

liangxin1300 commented Jan 3, 2025

Uh oh!

liangxin1300 commented Jan 3, 2025

Uh oh!

zzhou1 commented Jan 6, 2025

Uh oh!

liangxin1300 left a comment

Uh oh!

Uh oh!

Uh oh!

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

Dev: migration: implement corosync.conf migration for corosync 3 (jsc#PED-8252) #1422

Uh oh!

Conversation

nicholasyang2022 commented May 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Use Cases

Check When All Green for Migration

Check When Already Migrated

Run Migration

Try to Run Migration When Already Migrated

Uh oh!

codecov bot commented May 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

liangxin1300 commented Jan 3, 2025

Uh oh!

liangxin1300 commented Jan 3, 2025

Uh oh!

zzhou1 commented Jan 6, 2025

Uh oh!

liangxin1300 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nicholasyang2022 commented May 16, 2024 •

edited

Loading

codecov bot commented May 16, 2024 •

edited

Loading