Skip to content

Dev: Hide lsb and service resource agent class type from UI and doc #1423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented May 20, 2024

No description provided.

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.74%. Comparing base (ea6db17) to head (ea4ee5d).

Files Patch % Lines
crmsh/ra.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1423      +/-   ##
==========================================
- Coverage   53.75%   53.74%   -0.01%     
==========================================
  Files          80       80              
  Lines       24059    24060       +1     
==========================================
  Hits        12932    12932              
- Misses      11127    11128       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 changed the title Dev: Hide lsb and service resource agent class type from UI and doc (… Dev: Hide lsb and service resource agent class type from UI and doc May 29, 2024
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a PED to be referenced?

else:
l = ["heartbeat", "lsb", "ocf", "stonith", "systemd"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is heartbeat related to lsb?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"heartbeat" is used by the current ocf1.0 and 1.1 standard and located at
/usr/lib/ocf/resource.d/heartbeat

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# crm_resource --list-standards
ocf
lsb
service
systemd
stonith

Just synced with the output of --list-standards

@zzhou1
Copy link
Contributor

zzhou1 commented May 29, 2024

Is there a PED to be referenced?

Let's wait few moment till the Impl. Task PED get created.

@liangxin1300
Copy link
Collaborator Author

Is there a PED to be referenced?

Let's wait few moment till the Impl. Task PED get created.

Now I write jsc#PED-5577 in commit message

@liangxin1300 liangxin1300 merged commit c078907 into ClusterLabs:master Jun 6, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants