Skip to content

Dev: log an error when fencing node without stonith device configured and running #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented May 27, 2024

When running crm node fence or crm cluster crash_test --fence-node, should check if stonith device configured and running, if not, log an error and return False

@liangxin1300 liangxin1300 changed the title Dev: log an error when fencing node without stonith device configured… Dev: log an error when fencing node without stonith device configured and running May 27, 2024
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 53.72%. Comparing base (ea6db17) to head (230fff0).
Report is 2 commits behind head on master.

Files Patch % Lines
crmsh/crash_test/task.py 0.00% 3 Missing ⚠️
crmsh/crash_test/utils.py 0.00% 3 Missing ⚠️
crmsh/ui_node.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1425      +/-   ##
==========================================
- Coverage   53.75%   53.72%   -0.03%     
==========================================
  Files          80       80              
  Lines       24059    24071      +12     
==========================================
+ Hits        12932    12933       +1     
- Misses      11127    11138      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review May 28, 2024 02:30
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicholasyang2022 nicholasyang2022 merged commit d55edf8 into ClusterLabs:master May 28, 2024
29 of 30 checks passed
nicholasyang2022 added a commit that referenced this pull request May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants