Skip to content

[crmsh-4.6] Dev: log an error when fencing node without stonith device configured and running #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented May 27, 2024

backport #1425

Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 53.11%. Comparing base (37a1c4e) to head (7fc75ba).
Report is 2 commits behind head on crmsh-4.6.

Files Patch % Lines
crmsh/crash_test/task.py 0.00% 3 Missing ⚠️
crmsh/ui_node.py 0.00% 3 Missing ⚠️
crmsh/crash_test/utils.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           crmsh-4.6    #1426      +/-   ##
=============================================
- Coverage      53.12%   53.11%   -0.02%     
=============================================
  Files             79       79              
  Lines          23974    23985      +11     
=============================================
+ Hits           12737    12739       +2     
- Misses         11237    11246       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review May 28, 2024 02:31
@nicholasyang2022 nicholasyang2022 merged commit 85681c6 into ClusterLabs:crmsh-4.6 May 28, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants