Dev: coverage: inject coverage with sitecustomize.py in feature tests #1458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to inject the coverage in the program entrance /usr/sbin/crm. However, crm.report uses multiprocessing and the child processes does not execute code in /usr/sbin/crm. So its coverage cannot be caculated. This patch use an alternative method, by using sitecustomize.py, to inject the coverage. It should work for all python processes.
This reverts commit 5f1fb4d.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
nicholasyang2022
deleted the
feature-test-coverage-injected-by-sitecustomize-7.53
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With python-coverage updated to 7.5.3 from 4.x, code called with
multiprocessingis able to be measured now.This is an refreshed version of #1297.