Skip to content

Dev: ra: Guess stonith class type when using fence agents #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Jun 19, 2024

Problem

When adding fence agent without giving stonith class, get an error while using Tab to get parameters

crm(live/alp-1)configure# primitive stonith-sbd fence_sbd params ERROR: ocf:heartbeat:fence_sbd: got no meta-data, does this RA exist?

That is allowed when adding ocf RA without giving ocf class

crm(live/alp-1)configure# primitive d Dummy params 
fake=    state=

Solution

In ra.disambiguate_ra_type function, return 'stonith' class type when RA starts with 'fence_'

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.99%. Comparing base (c807292) to head (e9f9d42).
Report is 10 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
integration 53.95% <66.66%> (+0.16%) ⬆️
unit 50.34% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
crmsh/ra.py 52.21% <66.66%> (-0.01%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liangxin1300 liangxin1300 marked this pull request as ready for review June 20, 2024 00:49
@liangxin1300 liangxin1300 merged commit 4a694b7 into ClusterLabs:master Jun 20, 2024
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants