Skip to content

Find Method Picker #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 30, 2025
Merged

Find Method Picker #322

merged 8 commits into from
May 30, 2025

Conversation

austincondiff
Copy link
Collaborator

@austincondiff austincondiff commented May 28, 2025

Description

Added find method picker that changes the method by which text is found. Options include:

  • Contains
  • Match Word
  • Starts With
  • Ends With
  • Regular Expression

Related Issues

Checklist

  • I read and understood the contributing guide as well as the code of conduct
  • The issues this PR addresses are related to each other
  • My changes generate no new warnings
  • My code builds and runs on my machine
  • My changes are all related to the related issue above
  • I documented my code

Screenshots

Screen.Recording.2025-05-28.at.4.07.59.PM.mov
image image image image

Copy link
Collaborator

@thecoolwinter thecoolwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a crash while messing around, we should probably fix the crash itself in CETV but it should be fixed here too.

@thecoolwinter
Copy link
Collaborator

It's concerning that we don't have any tests for the find panel besides the height changes.

@austincondiff
Copy link
Collaborator Author

Fixed the tests, we should be good to go! ✅

@thecoolwinter thecoolwinter merged commit 9339c42 into main May 30, 2025
2 checks passed
@thecoolwinter thecoolwinter deleted the feat/find-method branch May 30, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants