Fix Overlapping Lines Method #326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the
getHighlightedLines
method to get the text line instead of the visible line. This difference was pointed out in #259 when @Bogdan-Belogurov pointed out that a selection would select the line it ended on instead of the lines it contained.This fix matches other editor's behavior, where selecting a line including the newline does not include the next line when applying a transformation.
Xcode example
An example is Xcode when indenting a selected line, note that the selection includes the newline character, but does not move the next line. Right now, CodeEdit moves the next line too.
Screen.Recording.2025-05-30.at.10.59.43.AM.mov
Related Issues
Checklist
Screenshots
Screen.Recording.2025-05-30.at.11.00.36.AM.mov