Skip to content

Commit 0e6fcc0

Browse files
committed
fix(sdk): fixed useless warning
1 parent df23912 commit 0e6fcc0

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

playground/misc/misc-3-release-notes.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,12 @@
22

33
The CodinGame SDK is regularly updated and improved. This document lets you know what changed in the latest releases.
44

5+
## Next version
6+
7+
### 🐞 Bug fix
8+
9+
- Removed "missing welcome_en.html file" warning.
10+
511
## 4.4.4
612

713
### 🐞 Bug fix

runner/src/main/java/com/codingame/gameengine/runner/Renderer.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -453,11 +453,11 @@ private void checkUniqueOpti(GameConfig gameConfig, ExportReport exportReport) {
453453

454454
private void checkLeaguePopups(QuestionConfig questionConfig, String tag, ExportReport exportReport) {
455455
if (
456-
!questionConfig.getWelcomeLanguageMap().containsKey(Constants.LANGUAGE_ID_ENGLISH)
457-
|| questionConfig.getWelcomeLanguageMap().get(Constants.LANGUAGE_ID_ENGLISH).isEmpty()
456+
questionConfig.getWelcomeLanguageMap().containsKey(Constants.LANGUAGE_ID_ENGLISH)
457+
&& questionConfig.getWelcomeLanguageMap().get(Constants.LANGUAGE_ID_ENGLISH).isEmpty()
458458
) {
459459
exportReport.addItem(
460-
ReportItemType.WARNING, tag + "Missing welcome_"
460+
ReportItemType.WARNING, tag + "Empty welcome_"
461461
+ Constants.LANGUAGE_CODE[Constants.LANGUAGE_ID_ENGLISH - 1] + ".html file."
462462
);
463463
} else {

0 commit comments

Comments
 (0)