Update to VScode 1.101.0 #639
Open
+1,636
−1,132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGNonofr
reviewed
Jun 18, 2025
| 'vs/workbench/services/extensionManagement/common/media/defaultIcon.png': new URL( | ||
| '../../vscode/src/vs/workbench/services/extensionManagement/common/media/defaultIcon.png', | ||
| import.meta.url | ||
| ).toString(), |
There was a problem hiding this comment.
What happened to that icon? 🤔
There was a problem hiding this comment.
It was removed in this commit
demo/src/setup.common.ts
Outdated
| @@ -76,7 +76,6 @@ import getSurveyServiceOverride from '@codingame/monaco-vscode-survey-service-ov | |||
| import getUpdateServiceOverride from '@codingame/monaco-vscode-update-service-override' | |||
| import getExplorerServiceOverride from '@codingame/monaco-vscode-explorer-service-override' | |||
| import getLocalizationServiceOverride from '@codingame/monaco-vscode-localization-service-override' | |||
| import getTreeSitterServiceOverride from '@codingame/monaco-vscode-treesitter-service-override' | |||
There was a problem hiding this comment.
What happened to that service override?
I'm still able to find related services in the VSCode code base, like ITreeSitterLibraryService or ITreeSitterThemeService
There was a problem hiding this comment.
I had missed these 2 new services they added. Here's the fix (which rollback the removal of the service override): 1cdba72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope what I've done is correct 😅
I tested all the mode combinations in the demo, doing all the actions I had in mind. I didn't see an error anywhere