Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make zoomed-in UI usable #16

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Make zoomed-in UI usable #16

merged 1 commit into from
Aug 20, 2024

Conversation

kwinto
Copy link
Contributor

@kwinto kwinto commented Aug 19, 2024 •
edited
Loading

Success criteria

Please describe what should be possible after this change. List all individual items on a separate line.

  • UI is usable when zoomed to 200%

How to test

Please describe the individual steps on how a peer can test your change.

  1. Use this endpoint: https://endpoint-trial.cognigy.ai/72c7b41039cebf9f3ecc3d0f5cdd83057927cdf5b640bca81d0ec5d94c174af5
  2. Open Webchat, zoom browser to 200%

Security

  • Possible injection vector
  • Authentication/Access controls touched
  • Sensitive Data could be exposed
  • XSS
  • Logging/Monitoring touched
  • Exchanges data with external systems
  • No security implications

Additional considerations

  • This PR might have performance implications

@kwinto kwinto requested a review from sushmi21 August 19, 2024 10:38
@kwinto kwinto merged commit aebcc4a into main Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sushmi21 sushmi21 sushmi21 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwinto @sushmi21