Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with controlCommands messages #17

Merged
merged 6 commits into from
Aug 26, 2024

Conversation

fabclj
Copy link
Contributor

@fabclj fabclj commented Aug 21, 2024

Success criteria

  • Fixed a bug where after Rating submit, if last message is a QR, all buttons get disabled.
  • Fixed a bug where after Privacy Notice submit, the messages collation feature was not working.

Both bugs are visible in this screenshot, where it was submitted the privacy message and also the rating:

Screenshot from 2024-08-21 13-18-39

How to test

  1. Deploy the widget locally using this endpoint:
    https://endpoint-dev.cognigy.ai/51083847963e64f271308e3e940057f8a353b80e4a5579d96dec292202a6c236
  2. Submit first the Privacy notice. The collation should work as expected
  3. Open chat options and submit the rating.
  4. Go back to the chat and check the QR buttons. They should be still enabled.

Compare with DEV, where you will see the bugs in action:
https://webchat-dev.cognigy.ai/v3/51083847963e64f271308e3e940057f8a353b80e4a5579d96dec292202a6c236

@fabclj fabclj changed the title Fix issues with controlCommands messages: QR disabling and messages collation Fix issues with controlCommands messages Aug 21, 2024
@fabclj fabclj requested review from sushmi21 and kwinto August 21, 2024 14:46
@fabclj fabclj marked this pull request as ready for review August 21, 2024 14:59
@sushmi21 sushmi21 merged commit 1f5c09e into main Aug 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants