-
Notifications
You must be signed in to change notification settings - Fork 4
Removed relative positioning from scrollable chat area #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The scroll button is also visible inside the persistent menu. Can we hide the scroll button when the persistent menu is open? |
how do I open the persistent menu? |
you need to set it up in the endpoint editor . It might be tricky to hide it I think , The logic to open the menu is in WebchatUI |
Okay I see it. hiding the button is not the solution here, we need to position it relatively to the scrollable chat area again. Either by changing the date picker to position itself differently, e.g. using portal, or by constantly measuring the input area and positioning the scroll button with a calculation of this measurement. But we can't do either in a quick fix here |
Okay, then we can merge this and see if we can find a better solution in a follow-up. |
Rest looks fine |
how about I quickly add a setting to disable this button? then it can be at least disabled from the endpoint in case there is issues |
or even better, we hide it by default for now |
You mean the scroll button ? |
ok then feel free to merge and proceed. otherwise please let me know |
There is a conflict in positioning relative to the parent container between the opened date picker and the "scroll-to-bottom"-button. This PR removes the relative positioning from the scrollable area that was introduced to position the scroll-button.
see here for how it should look (and looks with this fix):
This "fix" now leads to another issue: If the input area grows (due to long text in it) AND the scroll-button is visible, it will be displayed on top of the input area. see screenshot below.
Success criteria
How to test
Please describe the individual steps on how a peer can test your change.
Security
Additional considerations
Documentation Considerations
These are hints for the documentation team to help write the docs.