Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/87618 fix start behavior with privacy screen #83

Merged
merged 5 commits into from
Mar 26, 2025

Conversation

sushmi21
Copy link
Contributor

Success criteria

  • The 'Start with a button' behavior should display the get started button even in the presence of privacy screen
  • Clicking conversation starter in home screen or teaser message when 'Auto send message to bot' start behavior is configured should not behave differently with and without privacy screen
  • The order in which the conversation starter and get started message is sent when 'enableInjectionWithoutEmptyHistory' is true should be same with and without privacy screen.
  • Focus style of Get started button is consistent with rest of the buttons in v3

How to test

Test 1:
- Enable Privacy Notice
- Configure the start behavior to 'Start with a button'
- Now open the webchat and accept the privacy notice. After this, a chat screen with a button should be shown.

Test 2:
- Enable Privacy notice
- Configure the start behavior to 'Auto send message to bot'
- Enable Home screen and add some conversation starters
- Now open webchat and click on the conversation starter in the home screen.
- Accept the privacy screen that is shown. After this only conversation starter message should be sent in the chat (The chat should work in the same way even when there is no privacy screen)
- Repeat the same test by configuring teaser message with conversation starters and test the conversation starter button clicks with and without privacy screen

Test 3:
- Enable Privacy notice
- Configure the start behavior to 'Auto send message to bot'
- Enable Home screen and add some conversation starters
- Set enableInjectionWithoutEmptyHistory to true
- Now open webchat and click on the conversation starter in the home screen.
- Accept the privacy screen that is shown. After this conversation starter message should be sent followed by get started message (The chat should work in the same way even when there is no privacy screen)
- Repeat the same test by configuring teaser message with conversation starters and test the conversation starter button clicks with and without privacy screen

Test 4:
- Configure the start behavior to 'Start with a button'
- Focus the button using keyboard. The focus style should be same as the 'Start conversation' button in the home screen.

Security

  • No security implications

Documentation Considerations

None

@sushmi21
Copy link
Contributor Author

I am investigating the failing tests at the moment

Copy link
Contributor

@vj-venkatesan vj-venkatesan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all scenarios works as expected

Copy link
Contributor

@kwinto kwinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sushmi21 sushmi21 merged commit a4900e5 into main Mar 26, 2025
5 checks passed
@vj-venkatesan vj-venkatesan mentioned this pull request Mar 28, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants