-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix persistent history when used with teaser message #85
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where the chat history was not properly restored when using a teaser message.
- Adds a RESET_STATE action to conditionally restore persisted messages if the current message history is empty.
- Uses a specific condition to detect an "empty" history (or history with only an engagement message) to avoid duplicates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there are multiple conversations (Through previous conversations) and I start a new conversation and follow your steps, the teaser always takes me to the oldest conversation
Say the following chat history
- C (Recent)
- B
- A
Clicking teaser always goes to A , is that we want ?
If you have a distinct session id configured, it will always open that conversation. |
Ah yes that makes sense , what If i don't have a distinct session ? |
It will then generate a random id for the session. So, the "Start conversation" button and the teaser message bubble would always lead to a new conversation. |
Success criteria
Please describe what should be possible after this change. List all individual items on a separate line.
How to test
Please describe the individual steps on how a peer can test your change.