Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix persistent history when used with teaser message #85

Merged
merged 2 commits into from
Mar 28, 2025
Merged

Fix persistent history when used with teaser message #85

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
250c1ce
fix persistent history when used with teaser message
kwinto Mar 27, 2025
bdc8bb9
Merge branch 'main' into bug/87720-teaser-message-with-persisted-history
kwinto Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/webchat/store/reducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ import {
import { StoreState } from "./store";
import xAppOverlay from "./xapp-overlay/slice";
import queueUpdates from "./queue-updates/slice";
import { IStreamingMessage } from "../../common/interfaces/message";

const rootReducer = (state, action) => {
const combinedReducer = combineReducers({
Expand Down Expand Up @@ -53,18 +52,19 @@ export type SetPrevStateAction = ReturnType<typeof setPrevState>;

export const reducer = (state = rootReducer(undefined, { type: "" }), action) => {
switch (action.type) {
// This is actually "Restore persisted history"
case "RESET_STATE": {
// To avoid duplicate messages in chat history during re-connection, we only restore messages and prepend them if the current message history is empty
const isEmptyHistory =
state.messages.messageHistory.length === 0 ||
(state.messages.messageHistory.length === 1 &&
state.messages.messageHistory[0].source === "engagement");
const messages = isEmptyHistory ? action.state.messages : [];
return rootReducer(
{
...state,
messages: {
messageHistory: [
// To avoid duplicate messages in chat history during re-connection, we only restore messages and prepend them if the current message history is empty
...(state.messages.messageHistory.length === 0
? action.state.messages
: []),
...state.messages.messageHistory,
],
messageHistory: [...messages, ...state.messages.messageHistory],
visibleOutputMessages: state.messages.visibleOutputMessages,
},
rating: {
Expand Down