-
Notifications
You must be signed in to change notification settings - Fork 4
Feature/#94258 extend aria label translations #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#94258 extend aria label translations #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/webchat-ui/components/plugins/input/file/PreviewUploadedFiles.tsx:114
- [nitpick] The variable name 'removeFileAttachment' is ambiguous since it represents an aria-label value; consider renaming it to 'removeFileAttachmentLabel' to improve clarity.
aria-label={`${removeFileAttachment ?? "Remove File Attachment"} ${index + 1}`}
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… embedding documentation
… modal components
…roved accessibility
Looks good. There are some aria-labels in the chat-components repo too. That can go in a follow-up PR as well. Also, in addition to aria-labels, we have hidden screen-reader only texts that also needs translation :( |
This is not a lot , I can include it in the same PR . wdyt ? |
Ah I did not know that , are they hard coded there ? |
Yes. There are aria-labels and screen-reader-only texts in chat-components too |
I have resolved all your comments and added SR only texts. Could you please check again ? As agreed will create a follow up for integrating chat components |
…ory, home screen, and new message preview
docs/embedding.md
Outdated
| thumbsDown | string | "Thumbs down" | Label for the negative feedback button. | | ||
| openConversation | string | "Open conversation" | Label for the button that opens a conversation thread. | | ||
|
||
#### Screen reader |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: I think ariaLabels and Screen-reader objects can be combined. Both aria-label and screen-reader only texts are not visible in the screen and used by screen readers. So, it does not make a difference to our customer building a bot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this
Success criteria
Please describe what should be possible after this change. List all individual items on a separate line.
How to test
Please describe the individual steps on how a peer can test your change.
ariaLabels
setting insidecustomTranslations
and modify any labelsSecurity
Additional considerations
Documentation Considerations
These are hints for the documentation team to help write the docs.